Skip to content

OCPBUGS-54731: Distinguished among IPI and UPI in nw-dual-stack-conve… #91857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

OCPBUGS-54731: Distinguished among IPI and UPI in nw-dual-stack-conve… #91857

merged 1 commit into from
May 2, 2025

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Apr 8, 2025 •
edited
Loading

Version(s):
4.16+

Issue:
OCPBUGS-54731

Link to docs preview:
Converting to a dual-stack cluster network

  • SME has approved this change.
  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 8, 2025
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-54731, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.16+

Issue:
OCPBUGS-54731

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 8, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 8, 2025 •
edited
Loading

🤖 Fri May 02 15:55:58 - Prow CI generated the docs preview:

https://91857--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ovn_kubernetes_network_provider/converting-to-dual-stack.html

cybertron
cybertron suggested changes Apr 8, 2025
View reviewed changes
Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing inline, but otherwise LGTM

@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 9, 2025
@mburke5678
Copy link
Contributor

@dfitzmau A few comments. Otherwise LGTM.

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 9, 2025
@cybertron
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@rbbratta
Copy link

rbbratta commented May 2, 2025

/lgtm

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 2, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 2, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-54731, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.16+

Issue:
OCPBUGS-54731

Link to docs preview:
Converting to a dual-stack cluster network

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 2, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau merged commit c06eeaa into openshift:main May 2, 2025
2 checks passed
@openshift-ci-robot
Copy link

@dfitzmau: Jira Issue OCPBUGS-54731 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Version(s):
4.16+

Issue:
OCPBUGS-54731

Link to docs preview:
Converting to a dual-stack cluster network

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2025

/cherrypick enterprise-4.19

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2025

/cherrypick enterprise-4.18

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2025

/cherrypick enterprise-4.17

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2025

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92945

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92946

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92947

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92948

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@cybertron cybertron cybertron requested changes

Assignees

@cybertron cybertron

@rbbratta rbbratta

Labels
branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @mburke5678 @cybertron @rbbratta @openshift-cherrypick-robot @ocpdocs-vale-bot